blockservice: remove deprecated NewWriteThrough function #565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 15, 2024
Merged
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
This was referenced Jan 15, 2024
Closed
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## blockservice-stop-using-NewWriteThrough-in-tests #565 +/- ##
====================================================================================
+ Coverage 65.16% 65.47% +0.30%
====================================================================================
Files 204 207 +3
Lines 25597 25621 +24
====================================================================================
+ Hits 16681 16775 +94
+ Misses 7433 7366 -67
+ Partials 1483 1480 -3
|
hacdias
approved these changes
Jan 15, 2024
Base automatically changed from
blockservice-stop-using-NewWriteThrough-in-tests
to
blockservice-opt
January 15, 2024 17:20
Jorropo
deleted the
01-15-blockservice_remove_deprecated_NewWriteThrough_function
branch
This was referenced Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is it time ?